[llvm-commits] [llvm] r160293 - in /llvm/trunk/lib/Target/X86: X86FrameLowering.cpp X86MachineFunctionInfo.h

[Alexey Samsonov]

Indeed. Thanks!

On Mon, Jul 16, 2012 at 9:42 PM, Chad Rosier <mcrosier at apple.com> wrote:

> Author: mcrosier
> Date: Mon Jul 16 12:42:13 2012
> New Revision: 160293
>
> URL: http://llvm.org/viewvc/llvm-project?rev=160293&view=rev
> Log:
> With r160248 in place this code is no longer needed.
>
> Modified:
>     llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
>     llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h
>
> Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=160293&r1=160292&r2=160293&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Mon Jul 16 12:42:13 2012
> @@ -936,8 +936,6 @@
>      BuildMI(MBB, MBBI, DL, TII.get(Opc), BasePtr)
>        .addReg(StackPtr)
>        .setMIFlag(MachineInstr::FrameSetup);
> -
> -    X86FI->setBasePtrStackAdjustment(NumBytes);
>    }
>
>    if (( (!HasFP && NumBytes) || PushedRegs) && needsFrameMoves) {
>
> Modified: llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h?rev=160293&r1=160292&r2=160293&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h (original)
> +++ llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h Mon Jul 16 12:42:13
> 2012
> @@ -69,10 +69,6 @@
>    /// NumLocalDynamics - Number of local-dynamic TLS accesses.
>    unsigned NumLocalDynamics;
>
> -  /// After the stack pointer has been restore from the base pointer we
> -  /// use a cached adjusment.
> -  int64_t BPAdj;
> -
>  public:
>    X86MachineFunctionInfo() : ForceFramePointer(false),
>                               CalleeSavedFrameSize(0),
> @@ -101,8 +97,7 @@
>        VarArgsGPOffset(0),
>        VarArgsFPOffset(0),
>        ArgumentStackSize(0),
> -      NumLocalDynamics(0),
> -      BPAdj(0) {}
> +      NumLocalDynamics(0) {}
>
>    bool getForceFramePointer() const { return ForceFramePointer;}
>    void setForceFramePointer(bool forceFP) { ForceFramePointer = forceFP; }
> @@ -143,15 +138,6 @@
>    unsigned getNumLocalDynamicTLSAccesses() const { return
> NumLocalDynamics; }
>    void incNumLocalDynamicTLSAccesses() { ++NumLocalDynamics; }
>
> -  /// setBasePtrStackAdjustment - If we're restoring the stack pointer
> from the
> -  /// base pointer, due to dynamic stack realignment + VLAs, we cache the
> -  /// number of bytes initially allocated for the stack frame.  In obscure
> -  /// cases (e.g., tail calls with byval argument and no stack
> protector), the
> -  /// stack gets adjusted outside of the prolog, but these shouldn't be
> -  /// considered when restoring from the base pointer.  Currently, this
> is only
> -  /// needed for x86.
> -  void setBasePtrStackAdjustment(int64_t adj) { BPAdj = adj; }
> -  int64_t getBasePtrStackAdjustment() const { return BPAdj; }
>  };
>
>  } // End llvm namespace
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120717/aeedd229/attachment.html>