Indeed. Thanks!<br><br><div class="gmail_quote">On Mon, Jul 16, 2012 at 9:42 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: mcrosier<br>
Date: Mon Jul 16 12:42:13 2012<br>
New Revision: 160293<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=160293&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=160293&view=rev</a><br>
Log:<br>
With r160248 in place this code is no longer needed.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86FrameLowering.cpp<br>
    llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=160293&r1=160292&r2=160293&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=160293&r1=160292&r2=160293&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Mon Jul 16 12:42:13 2012<br>
@@ -936,8 +936,6 @@<br>
     BuildMI(MBB, MBBI, DL, TII.get(Opc), BasePtr)<br>
       .addReg(StackPtr)<br>
       .setMIFlag(MachineInstr::FrameSetup);<br>
-<br>
-    X86FI->setBasePtrStackAdjustment(NumBytes);<br>
   }<br>
<br>
   if (( (!HasFP && NumBytes) || PushedRegs) && needsFrameMoves) {<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h?rev=160293&r1=160292&r2=160293&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h?rev=160293&r1=160292&r2=160293&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h (original)<br>
+++ llvm/trunk/lib/Target/X86/X86MachineFunctionInfo.h Mon Jul 16 12:42:13 2012<br>
@@ -69,10 +69,6 @@<br>
   /// NumLocalDynamics - Number of local-dynamic TLS accesses.<br>
   unsigned NumLocalDynamics;<br>
<br>
-  /// After the stack pointer has been restore from the base pointer we<br>
-  /// use a cached adjusment.<br>
-  int64_t BPAdj;<br>
-<br>
 public:<br>
   X86MachineFunctionInfo() : ForceFramePointer(false),<br>
                              CalleeSavedFrameSize(0),<br>
@@ -101,8 +97,7 @@<br>
       VarArgsGPOffset(0),<br>
       VarArgsFPOffset(0),<br>
       ArgumentStackSize(0),<br>
-      NumLocalDynamics(0),<br>
-      BPAdj(0) {}<br>
+      NumLocalDynamics(0) {}<br>
<br>
   bool getForceFramePointer() const { return ForceFramePointer;}<br>
   void setForceFramePointer(bool forceFP) { ForceFramePointer = forceFP; }<br>
@@ -143,15 +138,6 @@<br>
   unsigned getNumLocalDynamicTLSAccesses() const { return NumLocalDynamics; }<br>
   void incNumLocalDynamicTLSAccesses() { ++NumLocalDynamics; }<br>
<br>
-  /// setBasePtrStackAdjustment - If we're restoring the stack pointer from the<br>
-  /// base pointer, due to dynamic stack realignment + VLAs, we cache the<br>
-  /// number of bytes initially allocated for the stack frame.  In obscure<br>
-  /// cases (e.g., tail calls with byval argument and no stack protector), the<br>
-  /// stack gets adjusted outside of the prolog, but these shouldn't be<br>
-  /// considered when restoring from the base pointer.  Currently, this is only<br>
-  /// needed for x86.<br>
-  void setBasePtrStackAdjustment(int64_t adj) { BPAdj = adj; }<br>
-  int64_t getBasePtrStackAdjustment() const { return BPAdj; }<br>
 };<br>
<br>
 } // End llvm namespace<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div><br>