[llvm-commits] Directive parsing for AsmParser patch

Meador Inge meadori at codesourcery.com
Fri Jul 6 07:38:27 PDT 2012


On 07/03/2012 06:46 AM, Medic, Vladimir wrote:

> The reason for this is that error is reported in both X86AsmParser.cpp::ParseDirective
> and AsmParser.cpp::ParseStatement when code16 directive is found.

Right, but the change in error message behavior for this case for i386 is a
regression in behavior.  If this patch is applied, the i386 .code16 case should
be fixed such that it behaves the same as before.

> I've looked into all target implementations of ParseDirective and I don't see
> that this problem can occur in any of them.

That's good.

-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software



More information about the llvm-commits mailing list