[llvm-commits] Directive parsing for AsmParser patch

[Medic, Vladimir]

The reason for this is that error is reported in both X86AsmParser.cpp::ParseDirective and AsmParser.cpp::ParseStatement when code16 directive is found. I've looked into all target implementations of ParseDirective and I don't see that this problem can occur in any of them.
________________________________________
From: Meador Inge [meadori at codesourcery.com]
Sent: Tuesday, July 03, 2012 4:54 AM
To: Medic, Vladimir
Cc: llvm-commits at cs.uiuc.edu; Jovanovic, Petar
Subject: Re: [llvm-commits] Directive parsing for AsmParser patch

On Jun 28, 2012, at 10:21 AM, Medic, Vladimir wrote:

> Hi everyone,
> did somebody had a chance to look at the patch provided? It is not a large change so I think it won't take much time to review it.

I noticed one small issue while reviewing the code.  Upon encountering a '.code16' directive when assembling for i386-unknown-unknown the patched assembler produces:

   ../llvm-trunk/test/MC/AsmParser/directive_code32.s:5:2: error: unexpected directive .code16
           .code16
           ^
   ../llvm-trunk/test/MC/AsmParser/directive_code32.s:5:9: error: .code16 not supported yet
           .code16
                  ^
The current (unpatched) assembler produces the single error:

   ../llvm-trunk/test/MC/AsmParser/directive_code32.s:5:9: error: .code16 not supported yet
           .code16
                  ^

I am not sure if the change in ordering causes other problems or this is the only one.

--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software