[llvm-commits] [llvm] r159523 - in /llvm/trunk/test/CodeGen/CellSPU: icmp16.ll icmp32.ll icmp8.ll

[Chandler Carruth]

On Tue, Jul 3, 2012 at 7:42 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Jul 2, 2012, at 5:20 AM, Chandler Carruth wrote:
>
> > Author: chandlerc
> > Date: Mon Jul  2 07:20:14 2012
> > New Revision: 159523
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=159523&view=rev
> > Log:
> > Rewrite three tests that had truly egregious abuses of 'grep' in them to
> > use FileCheck.
> >
> > Aside from removing a dependence on TCL-style quoting, this also makes
> > the tests ... significantly more robust. =] It would be really, *really*
> > great of the maintainer(s) of the CellSPU backend went through and
> > systematically rewrite these tests to use FileCheck. There are a lot
> > more that have nearly this bad of abuses.
>
> Can we just remove the CellSPU backend?


I have no real opinions here. As rarely as I have to touch it, it costs me
fairly little. If maintainers don't step forward and modernize the testing,
I think it should get the axe just because we can't keep backends w/o
maintainers, but I don't think its nearly as broken as some of the others
have been prior to being removed.

That said, my exposure to the brokenness is *extremely* limited. Others may
have better insights into problems here if there are any...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120703/c04c5c41/attachment.html>