[llvm-commits] Patch: compiler-rt/lib/divsi3.c: do not call udivsi3 directly

Sébastien Bourdeauducq sebastien.bourdeauducq at lekernel.net
Fri Jun 22 02:35:53 PDT 2012


On 06/22/2012 10:10 AM, Anton Korobeynikov wrote:
>> The patch doesn't seem that obvious at first glance -
>> does your assumption about the compiler behavior always hold? (if yes,
>> please add
>> an explicit comment about it) Also, I'm not the author of the core
>> compiler-rt lib and don't know if optional hardware support is desirable here.
> +1 We should be careful here and not to introduce the cycle (divsi
> calls udivs which will end calling divsi again :) )

This problem is already present in the current code. How about this 
updated patch with a few comments?

S.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p2.diff
Type: text/x-patch
Size: 1217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120622/deb586ea/attachment.bin>


More information about the llvm-commits mailing list