[llvm-commits] Patch: compiler-rt/lib/divsi3.c: do not call udivsi3 directly

Anton Korobeynikov anton at korobeynikov.info
Fri Jun 22 01:10:38 PDT 2012


> The patch doesn't seem that obvious at first glance -
> does your assumption about the compiler behavior always hold? (if yes,
> please add
> an explicit comment about it) Also, I'm not the author of the core
> compiler-rt lib and don't know if optional hardware support is desirable here.
+1 We should be careful here and not to introduce the cycle (divsi
calls udivs which will end calling divsi again :) )
This seems to be not the case here, but we'll need to think about
possible problems...

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list