[llvm-commits] [llvm] r158536 - /llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

[Andrew Trick]

On Jun 15, 2012, at 1:30 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Fri, Jun 15, 2012 at 1:07 PM, Andrew Trick <atrick at apple.com> wrote:
> Author: atrick
> Date: Fri Jun 15 15:07:26 2012
> New Revision: 158536
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=158536&view=rev
> Log:
> LSR fix: "Special" users are just like "Basic" users but allow -1 scale.
> 
> Test case?

Yes, r158570, thanks for checking. I should have been in the same commit.
-Andy

> 
> Modified:
>    llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
> 
> Modified: llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp?rev=158536&r1=158535&r2=158536&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp Fri Jun 15 15:07:26 2012
> @@ -1308,8 +1308,8 @@
>     return !AM.BaseGV && AM.Scale == 0 && AM.BaseOffs == 0;
> 
>   case LSRUse::Special:
> -    // Only handle -1 scales, or no scale.
> -    return AM.Scale == 0 || AM.Scale == -1;
> +    // Special case Basic to handle -1 scales.
> +    return !AM.BaseGV && (AM.Scale == 0 || AM.Scale == -1) && AM.BaseOffs == 0;
>   }
> 
>   llvm_unreachable("Invalid LSRUse Kind!");
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120615/488480cc/attachment.html>