<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 15, 2012, at 1:30 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif"><font size="2"><div class="gmail_quote">On Fri, Jun 15, 2012 at 1:07 PM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">Author: atrick<br>
Date: Fri Jun 15 15:07:26 2012<br>
New Revision: 158536<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158536&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158536&view=rev</a><br>
Log:<br>
LSR fix: "Special" users are just like "Basic" users but allow -1 scale.<br></blockquote><div><br></div><div>Test case?</div></div></font></div></blockquote><div><br></div><div>Yes, r158570, thanks for checking. I should have been in the same commit.</div><div>-Andy</div><div><br></div><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif"><font size="2"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<br>
Modified:<br>
llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp?rev=158536&r1=158535&r2=158536&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp?rev=158536&r1=158535&r2=158536&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp Fri Jun 15 15:07:26 2012<br>
@@ -1308,8 +1308,8 @@<br>
return !AM.BaseGV && AM.Scale == 0 && AM.BaseOffs == 0;<br>
<br>
case LSRUse::Special:<br>
- // Only handle -1 scales, or no scale.<br>
- return AM.Scale == 0 || AM.Scale == -1;<br>
+ // Special case Basic to handle -1 scales.<br>
+ return !AM.BaseGV && (AM.Scale == 0 || AM.Scale == -1) && AM.BaseOffs == 0;<br>
}<br>
<br>
llvm_unreachable("Invalid LSRUse Kind!");<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></font></div>
</blockquote></div><br></body></html>