[llvm-commits] [lld] r158134 - in /lld/trunk: include/lld/Core/File.h include/lld/Core/Pass.h lib/ReaderWriter/PECOFF/ReaderCOFF.cpp lib/ReaderWriter/YAML/ReaderYAML.cpp

[Nick Kledzik]

On Jun 6, 2012, at 7:04 PM, Chandler Carruth wrote:
>  using llvm::object::coff_symbol;
> 
> +namespace lld {
> +
> 
> As this is in a '.cpp' file, shouldn't this be an anonymous namespace?
The warning I fixed was that createReaderCOFF() was not in the lld namespace as it prototype declares.  
But, yes the rest of the file should be in its own namespace.  I've committed a fix for that.

-Nick


>  
>  class COFFAbsoluteAtom : public AbsoluteAtom {
>  public:
>   COFFAbsoluteAtom(const File &F, llvm::StringRef N, uint64_t V)
> @@ -376,9 +377,10 @@
>  };
> 
> 
> -
>  Reader* createReaderPECOFF(const ReaderOptionsPECOFF &options) {
>   return new ReaderCOFF(options);
>  }
> 
> +} // namespace lld
> +
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120606/56f14f92/attachment.html>