<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 6, 2012, at 7:04 PM, Chandler Carruth wrote:</div><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "> using llvm::object::coff_symbol;<br><br>+namespace lld {<br>+<br></blockquote><div><br></div><div>As this is in a '.cpp' file, shouldn't this be an anonymous namespace?</div></span></blockquote><div>The warning I fixed was that createReaderCOFF() was not in the lld namespace as it prototype declares. </div><div>But, yes the rest of the file should be in its own namespace. I've committed a fix for that.</div><div><br></div><div>-Nick</div><div><br></div><br><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div> </div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "> class COFFAbsoluteAtom : public AbsoluteAtom {<br> public:<br> COFFAbsoluteAtom(const File &F, llvm::StringRef N, uint64_t V)<br>@@ -376,9 +377,10 @@<br> };<br><br><br>-<br> Reader* createReaderPECOFF(const ReaderOptionsPECOFF &options) {<br> return new ReaderCOFF(options);<br> }<br><br>+} // namespace lld<br>+<br><br><br></blockquote></span></blockquote></div><br></body></html>