[llvm-commits] [ASan] Make for-Windows RTL compileable using Clang++ (issue 6214063)

[Timur Iskhodzhanov]

Anton,

On Mon, May 21, 2012 at 6:03 PM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
>> -#ifdef _WIN32
>> +#if defined(_WIN32) && !defined(__clang__)
>>  #include <intrin.h>
>>  #endif
> I think it should check for _MSC_VER here instead. And in many other
> places as well.
Clang defines _MSC_VER on Windows:
$ clang++ -dM -E -xc empty | grep MSC
#define _MSC_EXTENSIONS 1
#define _MSC_VER 1300

>> +#if !defined(_WIN32) || defined(__clang__)
> So, on Win64 you will provide all this stuff regardless of compiler?
> This looks plain wrong.
on Win64 both _WIN32 and _WIN64 are defined.