[llvm-commits] [ASan] Make for-Windows RTL compileable using Clang++ (issue 6214063)

[Anton Korobeynikov]

Hi Timur,

> -#ifdef _WIN32
> +#if defined(_WIN32) && !defined(__clang__)
>  #include <intrin.h>
>  #endif
I think it should check for _MSC_VER here instead. And in many other
places as well.

>  #if defined(_WIN32)
> +# if defined(__clang__)
> +typedef int              intptr_t;
> +typedef unsigned int     uintptr_t;
> +# endif
These should go from stddef.h. What's the problem with it?

> +#if !defined(_WIN32) || defined(__clang__)
So, on Win64 you will provide all this stuff regardless of compiler?
This looks plain wrong.

Same problems in other places.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University