[llvm-commits] [PATCH] Missing bit definition for STR post reg instruction on ARM

[Silviu Baranga]

Committed in r156609.

 

Regards,

Silviu

 

From: Jim Grosbach [mailto:grosbach at apple.com] 
Sent: 10 May 2012 18:10
To: Silviu Baranga
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Missing bit definition for STR post reg instruction on
ARM

 

LGTM!

 

-Jim

 

On May 10, 2012, at 9:41 AM, Silviu Baranga <silbar01 at arm.com> wrote:





Hi,

 

The 4th bit of the STR (post reg) instruction in the ARM backend is
currently not defined. It should be set

to 0. This is causing other instructions(such as SEL) to be disassembled as
STR instructions. The patch

adds the missing definition.

 

The instructions that were being wrongly disassembled as STR instructions
also had missing unpredictable  

bitfield specifications. The patch also sets the bits in the "Unpredictable"
mask for these instructions.

 

We add regression tests for all the affected instructions.

 

Please review this patch.

 

Thanks,

Silviu

<sel.diff>

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120511/a93cd061/attachment.html>