[llvm-commits] [llvm] r155661 - /llvm/trunk/runtime/libprofile/CommonProfiling.c

[David Blaikie]

On Fri, Apr 27, 2012 at 8:17 AM, Benjamin Kramer
<benny.kra at googlemail.com> wrote:
>
> On 27.04.2012, at 15:23, Joerg Sonnenberger wrote:
>
>> On Fri, Apr 27, 2012 at 01:54:16PM +0100, James Molloy wrote:
>>> This commit causes our build to fail because of the use of C++ style
>>> comments in a file compiled for C90.
>>>
>>> Could you please change to C-style comments?
>>
>> Have you considered just using a C99 compiler?
>
> If you teach MSVC to understand the young C99 standard we can switch to compiling in C99 mode.
>
> GCC warns when it encounters a // comment in C89 mode, I suppose someone is using -Werror here.

It's nice to keep the bots warning free (I wouldn't mind a -Werror -
though we'd need to address or suppress a couple of things that show
up in GCC opt builds ("may be used initialized", mostly)). So I made
this change in r155726 - and it's just nice to be consistent with the
surrounding comments anyway.

- David