[llvm-commits] [llvm] r155456 - in /llvm/trunk: include/llvm/CodeGen/MachineScheduler.h include/llvm/CodeGen/ScheduleDAGInstrs.h lib/CodeGen/MachineScheduler.cpp lib/CodeGen/ScheduleDAGInstrs.cpp

[Andrew Trick]

On Apr 24, 2012, at 12:03 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Tue, Apr 24, 2012 at 10:56 AM, Andrew Trick <atrick at apple.com> wrote:
> Author: atrick
> Date: Tue Apr 24 12:56:43 2012
> New Revision: 155456
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=155456&view=rev
> Log:
> misched: DAG builder support for tracking register pressure within the current scheduling region.
> 
> The DAG builder is a convenient place to do it. Hopefully this is more
> efficient than a separate traversal over the same region.
> 
> Modified:
>    llvm/trunk/include/llvm/CodeGen/MachineScheduler.h
>    llvm/trunk/include/llvm/CodeGen/ScheduleDAGInstrs.h
>    llvm/trunk/lib/CodeGen/MachineScheduler.cpp
>    llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp
> 
> Modified: llvm/trunk/include/llvm/CodeGen/MachineScheduler.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineScheduler.h?rev=155456&r1=155455&r2=155456&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/CodeGen/MachineScheduler.h (original)
> +++ llvm/trunk/include/llvm/CodeGen/MachineScheduler.h Tue Apr 24 12:56:43 2012
> @@ -27,6 +27,7 @@
>  #ifndef MACHINESCHEDULER_H
>  #define MACHINESCHEDULER_H
> 
> +#include "RegisterClassInfo.h"
> 
> This doesn't seem right Andy... we're including a header from lib/CodeGen into a file in include/llvm/CodeGen. The latter files get installed, the former don't... It's breaking installed library usage (and it's breaking our layering checked builds).
> 
> Thoughts? Should this include go away? Should RegisterClassInfo.h move?
>  

Sorry, away from my desk longer than expected. That's horrible. Checking in a fix now.
-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120424/2b878ca4/attachment.html>