<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 24, 2012, at 12:03 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 24, 2012 at 10:56 AM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
Author: atrick<br>
Date: Tue Apr 24 12:56:43 2012<br>
New Revision: 155456<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=155456&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=155456&view=rev</a><br>
Log:<br>
misched: DAG builder support for tracking register pressure within the current scheduling region.<br>
<br>
The DAG builder is a convenient place to do it. Hopefully this is more<br>
efficient than a separate traversal over the same region.<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/CodeGen/MachineScheduler.h<br>
llvm/trunk/include/llvm/CodeGen/ScheduleDAGInstrs.h<br>
llvm/trunk/lib/CodeGen/MachineScheduler.cpp<br>
llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/CodeGen/MachineScheduler.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineScheduler.h?rev=155456&r1=155455&r2=155456&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineScheduler.h?rev=155456&r1=155455&r2=155456&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/CodeGen/MachineScheduler.h (original)<br>
+++ llvm/trunk/include/llvm/CodeGen/MachineScheduler.h Tue Apr 24 12:56:43 2012<br>
@@ -27,6 +27,7 @@<br>
#ifndef MACHINESCHEDULER_H<br>
#define MACHINESCHEDULER_H<br>
<br>
+#include "RegisterClassInfo.h"<br></blockquote><div><br></div><div>This doesn't seem right Andy... we're including a header from lib/CodeGen into a file in include/llvm/CodeGen. The latter files get installed, the former don't... It's breaking installed library usage (and it's breaking our layering checked builds).</div>
<div><br></div><div>Thoughts? Should this include go away? Should RegisterClassInfo.h move?</div><div> </div></div></div></blockquote><br></div><div>Sorry, away from my desk longer than expected. That's horrible. Checking in a fix now.</div><div>-Andy</div></body></html>