[llvm-commits] [PATCH] Additional SD-Node Cleanup after Combining Pass

[Hal Finkel]

Ping. (This is a one-line change, and I'd like to get this fixed for
Gabor).

Thanks again,
Hal

On Mon, 2 Apr 2012 22:56:33 -0500
Hal Finkel <hfinkel at anl.gov> wrote:

> The attached patch adds a call to CurDAG->RemoveDeadNodes() after the
> "DAG Combining 2" pass in SelectionDAGISel.cpp. This fixes PR12201.
> 
> Credit goes to Pete Cooper for figuring out the cause of the problem,
> and for providing this solution (see the bug report for the details).
> This might seem like overkill for the particular issue in PR12201,
> but I think that this PR highlights a corner case that should be
> dealt with generally (the alternatives seem to involve dealing with
> reference counting directly in the backends, and that seems messy).
> 
> http://llvm.org/bugs/show_bug.cgi?id=12201
> 
> Please let me know what you think. If this is ok to commit, then I'll
> do so.
> 
> Thanks again,
> Hal
> 



-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory