[llvm-commits] Additional SD-Node Cleanup after Combining Pass

Hal Finkel hfinkel at anl.gov
Mon Apr 2 20:56:33 PDT 2012

The attached patch adds a call to CurDAG->RemoveDeadNodes() after the
"DAG Combining 2" pass in SelectionDAGISel.cpp. This fixes PR12201.

Credit goes to Pete Cooper for figuring out the cause of the problem,
and for providing this solution (see the bug report for the details).
This might seem like overkill for the particular issue in PR12201, but I
think that this PR highlights a corner case that should be dealt with
generally (the alternatives seem to involve dealing with reference
counting directly in the backends, and that seems messy).


Please let me know what you think. If this is ok to commit, then I'll
do so.

Thanks again,

Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm_pr12201-20120402.patch
Type: text/x-patch
Size: 2396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120402/79b4fe7f/attachment.bin>

More information about the llvm-commits mailing list