[llvm-commits] [dragonegg] r153830 - in /dragonegg/trunk: include/dragonegg/Trees.h src/Constants.cpp

[Duncan Sands]

Hi PaX Team,

>> +#include "tree.h"
>> +#if (GCC_MINOR<  7)
>> +#include "flags.h" // For TYPE_OVERFLOW_UNDEFINED.
>> +#endif
>
> shouldn't these GCC_* version checks be based on the target gcc version (the one
> that will load the plugin and whose plugin headers are being included here) and not
> the host one (the one that builds the plugin, it doesn't even need to be gcc FWIW)?

it is, check out the Makefile.

Ciao, Duncan.

>
> i.e., i think you should use BUILDING_GCC_VERSION based checks instead, for this
> particular case:
>
> #if BUILDING_GCC_VERSION<= 4006
>
> cheers,
>   PaX Team
>