[llvm-commits] [dragonegg] r153830 - in /dragonegg/trunk: include/dragonegg/Trees.h src/Constants.cpp

[PaX Team]

On 1 Apr 2012 at 10:11, Duncan Sands wrote:

Hi,

> +#include "tree.h"
> +#if (GCC_MINOR < 7)
> +#include "flags.h" // For TYPE_OVERFLOW_UNDEFINED.
> +#endif

shouldn't these GCC_* version checks be based on the target gcc version (the one
that will load the plugin and whose plugin headers are being included here) and not
the host one (the one that builds the plugin, it doesn't even need to be gcc FWIW)?

i.e., i think you should use BUILDING_GCC_VERSION based checks instead, for this
particular case:

#if BUILDING_GCC_VERSION <= 4006

cheers,
 PaX Team