[llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/ un

[Nick Lewycky]

On 13 March 2012 23:23, Bendersky, Eli <eli.bendersky at intel.com> wrote:

>  Hi Nick,****
>
> ** **
>
> The empty file is a leftover from the patch. I’ve removed it in r152703***
> *
>
> As for the placement of the unit tests – we’ll take a look, thanks for
> noticing.
>

Okay, but in the future please do a proper "svn mv". You took a file with a
revision history and deleted it, then add a new file with the contents of
the old one. You've lost the revision history in the process.

Nick


> ****
>
> ** **
>
> Eli****
>
> ** **
>
> ** **
>
> ** **
>
> ** **
>
> *From:* Nick Lewycky [mailto:nlewycky at google.com]
> *Sent:* Tuesday, March 13, 2012 23:00
> *To:* Bendersky, Eli
> *Cc:* llvm-commits at cs.uiuc.edu
> *Subject:* Re: [llvm-commits] [llvm] r152620 - in /llvm/trunk: ./
> autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/
> lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/
> lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/ un***
> *
>
> ** **
>
> On 13 March 2012 01:33, Eli Bendersky <eli.bendersky at intel.com> wrote:****
>
> Author: eliben
> Date: Tue Mar 13 03:33:15 2012
> New Revision: 152620
>
> URL: http://llvm.org/viewvc/llvm-project?rev=152620&view=rev
> Log:
> Add profiling support for Intel Parallel Amplifier XE (VTune) for JITted
> code in LLVM.
>
> Also refactor the existing OProfile profiling code to reuse the same
> interfaces with the VTune profiling code.
> In addition, unit tests for the profiling interfaces were added.
>
> This patch was prepared by Andrew Kaylor and Daniel Malea, and reviewed in
> the llvm-commits list by Jim Grosbach
>
>
> Added:
>    llvm/trunk/include/llvm/ExecutionEngine/IntelJITEventsWrapper.h
>    llvm/trunk/include/llvm/ExecutionEngine/OProfileWrapper.h
>    llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h
>    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/
>    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt
>    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
>    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt
>    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/Makefile
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/CMakeLists.txt
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/LLVMBuild.txt
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/Makefile
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp
>    llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp
>    llvm/trunk/unittests/ExecutionEngine/IntelJITEventListenerTest.cpp
>    llvm/trunk/unittests/ExecutionEngine/JITEventListenerTest.cpp****
>
> ** **
>
> This is the first test in unittests/ExecutionEngine that relies on the
> JIT, the rest are all in ExecutionEngine/JIT. This is not a huge problem
> (it's just unit tests after all) so it's not a layering violation per se,
> but it is odd enough that our build system noticed it.****
>
> ** **
>
> Is there any reason that test shouldn't be in the ExecutionEngine/JIT
> directory?****
>
> ** **
>
> Actually it looks like you left
> ExecutionEngine/JIT/JITEventListenerTest.cpp an empty file. Please fix!***
> *
>
> ** **
>
> Nick****
>
> ** **
>   ---------------------------------------------------------------------
>
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120314/c2845f66/attachment.html>