<div class="gmail_quote">On 13 March 2012 23:23, Bendersky, Eli <span dir="ltr"><<a href="mailto:eli.bendersky@intel.com">eli.bendersky@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Nick,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">The empty file is a leftover from the patch. I’ve removed it in r152703<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">As for the placement of the unit tests – we’ll take a look, thanks for noticing.</span></p></div></div>
</blockquote><div><br></div><div>Okay, but in the future please do a proper "svn mv". You took a file with a revision history and deleted it, then add a new file with the contents of the old one. You've lost the revision history in the process.</div>
<div><br></div><div>Nick</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Eli<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Nick Lewycky [mailto:<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>]
<br>
<b>Sent:</b> Tuesday, March 13, 2012 23:00<br>
<b>To:</b> Bendersky, Eli<br>
<b>Cc:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/
un<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 13 March 2012 01:33, Eli Bendersky <<a href="mailto:eli.bendersky@intel.com" target="_blank">eli.bendersky@intel.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: eliben<br>
Date: Tue Mar 13 03:33:15 2012<br>
New Revision: 152620<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=152620&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=152620&view=rev</a><br>
Log:<br>
Add profiling support for Intel Parallel Amplifier XE (VTune) for JITted code in LLVM.<br>
<br>
Also refactor the existing OProfile profiling code to reuse the same interfaces with the VTune profiling code.<br>
In addition, unit tests for the profiling interfaces were added.<br>
<br>
This patch was prepared by Andrew Kaylor and Daniel Malea, and reviewed in the llvm-commits list by Jim Grosbach<br>
<br>
<br>
Added:<br>
llvm/trunk/include/llvm/ExecutionEngine/IntelJITEventsWrapper.h<br>
llvm/trunk/include/llvm/ExecutionEngine/OProfileWrapper.h<br>
llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/Makefile<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/CMakeLists.txt<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/LLVMBuild.txt<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/Makefile<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp<br>
llvm/trunk/unittests/ExecutionEngine/IntelJITEventListenerTest.cpp<br>
llvm/trunk/unittests/ExecutionEngine/JITEventListenerTest.cpp<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This is the first test in unittests/ExecutionEngine that relies on the JIT, the rest are all in ExecutionEngine/JIT. This is not a huge problem (it's just unit tests after all) so it's not a layering violation per se, but it is odd enough
that our build system noticed it.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Is there any reason that test shouldn't be in the ExecutionEngine/JIT directory?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Actually it looks like you left ExecutionEngine/JIT/JITEventListenerTest.cpp an empty file. Please fix!<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Nick<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
<font face="monospace">---------------------------------------------------------------------<div class="im"><br>
Intel Israel (74) Limited<br>
<br>
This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</div></font></div>
</blockquote></div><br>