[llvm-commits] [llvm] r150775 - in /llvm/trunk/lib/Target/Mips: ./ AsmParser/ InstPrinter/ MCTargetDesc/ TargetInfo/
Chris Lattner
clattner at apple.com
Fri Feb 17 01:19:00 PST 2012
On Feb 17, 2012, at 1:02 AM, Jia Liu wrote:
>>>> I think those files are the exceptions, and not the rules. I think the goal
>>>> is to have the minimum number of these required.
>>>
>>> Yes, my understanding was wrong.
>>
>> Yep, please remove these from .cpp files when you see them. Not a huge problem, but I'd appreciate it if you could remove them from the mips .cpp files too. Thanks!
>
> Thanks.
> Already done.
Thanks!
> Sorry again for my wrong patch.
No problem at all, that's what code review is for. Thanks again Jia,
-Chris
More information about the llvm-commits
mailing list