[llvm-commits] [llvm] r150775 - in /llvm/trunk/lib/Target/Mips: ./ AsmParser/ InstPrinter/ MCTargetDesc/ TargetInfo/

Jia Liu proljc at gmail.com
Fri Feb 17 01:02:48 PST 2012


On Fri, Feb 17, 2012 at 4:57 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Feb 16, 2012, at 8:24 PM, Jia Liu wrote:
>
>> On Fri, Feb 17, 2012 at 12:08 PM, Chandler Carruth <chandlerc at google.com> wrote:
>>> On Thu, Feb 16, 2012 at 8:02 PM, Jia Liu <proljc at gmail.com> wrote:
>>>>
>>>> Oh! Sorry. I thought it should be because I saw it in some other .cpp
>>>> files.
>>>
>>>
>>> I think those files are the exceptions, and not the rules. I think the goal
>>> is to have the minimum number of these required.
>>
>> Yes, my understanding was wrong.
>
> Yep, please remove these from .cpp files when you see them.  Not a huge problem, but I'd appreciate it if you could remove them from the mips .cpp files too.  Thanks!

Thanks.
Already done.

Sorry again for my wrong patch.

>
> -Chris

Regards,
Jia




More information about the llvm-commits mailing list