[llvm-commits] [PATCH] Random cleanup

Chris Lattner clattner at apple.com
Sun Feb 12 02:15:57 PST 2012

On Feb 11, 2012, at 10:43 PM, Ahmed Charles wrote:

> The only change I'm not sure about is the removal of llvm_unreachable,
> since it looks like an error, but it's always been that way and that
> path doesn't seem to be used (otherwise it'd get hit sometime). If
> someone knows more about that area, suggestions would be welcome.

This looks fine to me, please apply!


> Commit message:
> * Fix various issues (or do cleanups) found by enabling certain MSVC warnings.
> - Use unsigned literals when the desired result is unsigned. This
> mostly allows unsigned/signed mismatch warnings to be less noisy even
> if they aren't on by default.
> - Remove misplaced llvm_unreachable.
> - Add static to a declaration of a function on MSVC x86 only.
> - Change some instances of calling a static function through a
> variable to simply calling that function while removing the unused
> variable.
> <0001-Fix-various-issues-or-do-cleanups-found-by-enabling-.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list