[llvm-commits] [PATCH] Random cleanup

[Ahmed Charles]

The only change I'm not sure about is the removal of llvm_unreachable,
since it looks like an error, but it's always been that way and that
path doesn't seem to be used (otherwise it'd get hit sometime). If
someone knows more about that area, suggestions would be welcome.


Commit message:

* Fix various issues (or do cleanups) found by enabling certain MSVC warnings.

- Use unsigned literals when the desired result is unsigned. This
mostly allows unsigned/signed mismatch warnings to be less noisy even
if they aren't on by default.
- Remove misplaced llvm_unreachable.
- Add static to a declaration of a function on MSVC x86 only.
- Change some instances of calling a static function through a
variable to simply calling that function while removing the unused
variable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-various-issues-or-do-cleanups-found-by-enabling-.patch
Type: application/octet-stream
Size: 3955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120211/0b52ee17/attachment.obj>