[llvm-commits] [ASan] The first version of the RTL for Windows (issue 5647052)

[konstantin.s.serebryany at gmail.com]

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_allocator.cc
File lib/asan/asan_allocator.cc (right):

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_allocator.cc#newcode692
lib/asan/asan_allocator.cc:692: #if defined(_WIN32)
instead of the ifdef clatter, I'd prefer to have
if (WINDOWS)

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_interceptors.cc
File lib/asan/asan_interceptors.cc (right):

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_interceptors.cc#newcode32
lib/asan/asan_interceptors.cc:32: # include <intrin.h>  // FIXME: remove
when we start intercepting on Windows.
Why do you need this now?

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_interceptors.cc#newcode626
lib/asan/asan_interceptors.cc:626: #ifdef _WIN32
if (WINDOWS) please
or "if (ASAN_WINDOWS)"

also, feel free to change the code below to if (ASAN_APPLE)

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_win.cc
File lib/asan/asan_win.cc (right):

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_win.cc#newcode37
lib/asan/asan_win.cc:37: // FIXME: what is mem_type?
memtype is a string used for reporting mmap errors

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_win.cc#newcode98
lib/asan/asan_win.cc:98: ScopedLock lock(&dbghelp_lock);
OMG. Ok for now, but in the long run this is not going to work.
We will need our own unwinder.

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_win.cc#newcode167
lib/asan/asan_win.cc:167: AsanLock::AsanLock(LinkerInitialized li) {
This is in fact *not* linker-initialized.
Is there a way to create a linker-initialized lock on windows?

http://codereview.appspot.com/5647052/