[llvm-commits] [llvm] r149600 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrFragmentsSIMD.td lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/avx-sext.ll

[Demikhovsky, Elena]

In one of the projects I worked in, we used a code-sanity script that checked tabs, braces, spaces, line endings, 
line length and other aspects.

- Elena
-----Original Message-----
From: David A. Greene [mailto:dag at cray.com] 
Sent: Thursday, February 02, 2012 19:55
To: Chandler Carruth
Cc: Demikhovsky, Elena; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r149600 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrFragmentsSIMD.td lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/avx-sext.ll

Chandler Carruth <chandlerc at google.com> writes:

> This patch doesn't adhere to LLVM coding conventions very closely at
> all. Please try to make your code look more like the surrounding
> code. I've commented a few obvious places below.

While I agree with most of the comments on this patch, it would be
helpful if we had formatting/autoindent settings for various editors in
the repository somewhere, probably the utils/ folder.  A lot of the
alignment issues in this patch could be fixed with a quick C-M-\ in
emacs, for example.

In my experience, none of the default emacs CC-mode styles quite fits
LLVM.  I had to tweak a number of things and it's still not quite right.
I'm happy to submit those if people would find it useful.

Just a thought on how to better standardize formatting and make it
simpler for developers.

                                  -Dave
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.