[llvm-commits] [llvm] r149600 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86InstrFragmentsSIMD.td lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/avx-sext.ll

[David A. Greene]

Chandler Carruth <chandlerc at google.com> writes:

> This patch doesn't adhere to LLVM coding conventions very closely at
> all. Please try to make your code look more like the surrounding
> code. I've commented a few obvious places below.

While I agree with most of the comments on this patch, it would be
helpful if we had formatting/autoindent settings for various editors in
the repository somewhere, probably the utils/ folder.  A lot of the
alignment issues in this patch could be fixed with a quick C-M-\ in
emacs, for example.

In my experience, none of the default emacs CC-mode styles quite fits
LLVM.  I had to tweak a number of things and it's still not quite right.
I'm happy to submit those if people would find it useful.

Just a thought on how to better standardize formatting and make it
simpler for developers.

                                  -Dave