[llvm-commits] Optimization for TRUNCATE on AVX - please review

Demikhovsky, Elena elena.demikhovsky at intel.com
Mon Jan 30 07:46:34 PST 2012


I forgot about '{', I'll fix.

The function may be static. In this case I need to pass one more parameter.

- Elena

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tobias Grosser
Sent: Monday, January 30, 2012 16:29
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Optimization for TRUNCATE on AVX - please review

On 01/30/2012 03:11 PM, Demikhovsky, Elena wrote:
> Truncating from v4i64 to v4i32 and v8i32 to v8i16 may be done with set of shuffles on AVX.

Hi Elena,

no technical review, but some comments:

> +  if ((VT == MVT::v4i32)&&  (OpVT == MVT::v4i64))
> +  {

We normally put the '{' in the same line than the 'if'.

> Index: lib/Target/X86/X86ISelLowering.h
> ===================================================================
> --- lib/Target/X86/X86ISelLowering.h	(revision 149245)
> +++ lib/Target/X86/X86ISelLowering.h	(working copy)
> @@ -839,6 +839,8 @@
>       SDValue LowerMEMBARRIER(SDValue Op, SelectionDAG&DAG) const;
>       SDValue LowerATOMIC_FENCE(SDValue Op, SelectionDAG&DAG) const;
>       SDValue LowerSIGN_EXTEND_INREG(SDValue Op, SelectionDAG&DAG) const;
> +    SDValue PerformBrcondCombine(SDNode* N, SelectionDAG&DAG, DAGCombinerInfo&DCI) const;

Do you need to declare this function?

Cheers
Tobi
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the llvm-commits mailing list