[llvm-commits] Optimization for TRUNCATE on AVX - please review
Tobias Grosser
tobias at grosser.es
Mon Jan 30 06:29:28 PST 2012
On 01/30/2012 03:11 PM, Demikhovsky, Elena wrote:
> Truncating from v4i64 to v4i32 and v8i32 to v8i16 may be done with set of shuffles on AVX.
Hi Elena,
no technical review, but some comments:
> + if ((VT == MVT::v4i32)&& (OpVT == MVT::v4i64))
> + {
We normally put the '{' in the same line than the 'if'.
> Index: lib/Target/X86/X86ISelLowering.h
> ===================================================================
> --- lib/Target/X86/X86ISelLowering.h (revision 149245)
> +++ lib/Target/X86/X86ISelLowering.h (working copy)
> @@ -839,6 +839,8 @@
> SDValue LowerMEMBARRIER(SDValue Op, SelectionDAG&DAG) const;
> SDValue LowerATOMIC_FENCE(SDValue Op, SelectionDAG&DAG) const;
> SDValue LowerSIGN_EXTEND_INREG(SDValue Op, SelectionDAG&DAG) const;
> + SDValue PerformBrcondCombine(SDNode* N, SelectionDAG&DAG, DAGCombinerInfo&DCI) const;
Do you need to declare this function?
Cheers
Tobi
More information about the llvm-commits
mailing list