[llvm-commits] [llvm] r149216 - in /llvm/trunk/lib/Target/X86: X86ISelLowering.cpp X86ISelLowering.h X86InstrFragmentsSIMD.td X86InstrXOP.td

[Craig Topper]

On Sun, Jan 29, 2012 at 10:05 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Jan 29, 2012, at 5:10 PM, Craig Topper wrote:
>
> > Author: ctopper
> > Date: Sun Jan 29 19:10:15 2012
> > New Revision: 149216
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=149216&view=rev
> > Log:
> > Move some XOP patterns into instruction definition. Replae VPCMOV
> intrinsic patterns with custom lowering to a target specific nodes.
>
> Hi Craig,
>
> Would it make sense to replace the intrinsics with something that more
> closely matches what the code generator wants?  It would be really nice to
> reduce the # intrinsics and that huge switch.
>

Currently we have no code generator support for these instructions. But we
were previously wasting an awful lot of patterns on these. Hopefully this
is at least better than the patterns. I was wondering if it made more sense
to do the immediate selection on the clang side?


>
> -Chris
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120129/d338eb54/attachment.html>