[llvm-commits] [llvm] r148746 - /llvm/trunk/include/llvm/Support/CommandLine.h

[David Blaikie]

On Tue, Jan 24, 2012 at 1:06 AM, Duncan Sands <baldrick at free.fr> wrote:
> Hi David,
>
>> --- llvm/trunk/include/llvm/Support/CommandLine.h (original)
>> +++ llvm/trunk/include/llvm/Support/CommandLine.h Mon Jan 23 17:27:47 2012
>> @@ -163,12 +163,14 @@
>>     virtual void anchor();
>>
>>     int NumOccurrences;     // The number of times specified
>> -  enum NumOccurrencesFlag Occurrences : 3;
>> +  // Occurrences, HiddenFlag, and Formatting are all enum types but to avoid
>
> to avoid -> to avoid problems

Right

>> +  // with signed enums in bitfields in MSVC we'll store them as unsigned
>
> I'm not sure it is fair to name and shame MSVC here since (AFAIK) it is being
> perfectly standards conformant in its behaviour.

Agreed - when Chandler mentioned this it wasn't entirely clear whether
the issue was intrinsic to signed enums or to MSVC's implementation of
them. I'll reword the comment to give MSVC the benefit of the doubt.

committed in r148809

Thanks,
- David