[llvm-commits] [llvm] r148746 - /llvm/trunk/include/llvm/Support/CommandLine.h

Duncan Sands baldrick at free.fr
Tue Jan 24 01:06:00 PST 2012


Hi David,

> --- llvm/trunk/include/llvm/Support/CommandLine.h (original)
> +++ llvm/trunk/include/llvm/Support/CommandLine.h Mon Jan 23 17:27:47 2012
> @@ -163,12 +163,14 @@
>     virtual void anchor();
>
>     int NumOccurrences;     // The number of times specified
> -  enum NumOccurrencesFlag Occurrences : 3;
> +  // Occurrences, HiddenFlag, and Formatting are all enum types but to avoid

to avoid -> to avoid problems

> +  // with signed enums in bitfields in MSVC we'll store them as unsigned

I'm not sure it is fair to name and shame MSVC here since (AFAIK) it is being
perfectly standards conformant in its behaviour.

Ciao, Duncan.



More information about the llvm-commits mailing list