[llvm-commits] VECTOR_SUFFLE in avx - fixed - Please review

[Craig Topper]

r147525 added canonicalizing to DAGCombiner that should make shuffles of
two undefs turn into an undef. Is that code not working correctly for this
case?


On Wed, Jan 11, 2012 at 3:55 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Elena,
>
> > Fixed a bug in VECTOR_SHUFFLE
> > lc: X86ISelLowering.cpp:6480: llvm::SDValue
> llvm::X86TargetLowering::LowerVECTOR_SHUFFLE(llvm::SDValue,
> llvm::SelectionDAG&) const: Assertion `V1.getOpcode() != ISD::UNDEF&&  "Op
> 1 of shuffle should not be undef"' failed.
>
> if V1 is undef but V2IsUndef is false then you can now fall through to the
> following code.  How about at restoring the assertion, but putting it after
> your test.  While there, maybe introduce V1IsUndef for neatness.
>
> Ciao, Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120111/c07fefe7/attachment.html>