[llvm-commits] VECTOR_SUFFLE in avx - fixed - Please review

[Duncan Sands]

Hi Elena,

> Fixed a bug in VECTOR_SHUFFLE
> lc: X86ISelLowering.cpp:6480: llvm::SDValue llvm::X86TargetLowering::LowerVECTOR_SHUFFLE(llvm::SDValue, llvm::SelectionDAG&) const: Assertion `V1.getOpcode() != ISD::UNDEF&&  "Op 1 of shuffle should not be undef"' failed.

if V1 is undef but V2IsUndef is false then you can now fall through to the
following code.  How about at restoring the assertion, but putting it after
your test.  While there, maybe introduce V1IsUndef for neatness.

Ciao, Duncan.