[llvm-commits] [PATCH] asan-rt: fix signal wrapper on Android

[Kostya Serebryany]

Maybe we could simply drop the interceptor for signal() on android?
The only reason for the signal() interceptor is to disallow the users to
install their own SEGV handler.
Do we need it on Android? (my bet: we don't).

--kcc



On Tue, Jan 10, 2012 at 5:50 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com
> wrote:

> What do you think of this patch?
>
> On Thu, Dec 29, 2011 at 4:18 AM, Kostya Serebryany <kcc at google.com> wrote:
> > Can this be made with fewer ifdefs?
> >
> > e.g.
> > #ifdef ANDROID
> > # define SIGNAL_FUNC bsd_signal
> > #else
> > # define SIGNAL_FUNC signal
> > #endif
> >
> > What's wrong with __cxa_throw on android?
> >
> > --kcc
> >
> >
> > On Wed, Dec 21, 2011 at 3:52 AM, Evgeniy Stepanov
> > <eugeni.stepanov at gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> this patch wraps bsd_signal instead of signal on Android. Signal is a
> >> macro there.
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120110/617da073/attachment.html>