[llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD

Brian Anderson banderson at mozilla.com
Mon Jan 9 18:05:22 PST 2012


Thanks for the review, Rafael. New patches attached. Responses inline below.

----- Original Message -----
> From: "Rafael Ávila de Espíndola" <rafael.espindola at gmail.com>
> To: "Brian Anderson" <banderson at mozilla.com>
> Cc: "Anton Korobeynikov" <anton at korobeynikov.info>, llvm-commits at cs.uiuc.edu, "Rafael Espindola"
> <respindola at mozilla.com>
> Sent: Monday, January 9, 2012 1:51:53 PM
> Subject: Re: [llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD
> 
> > Thanks for the review, Anton. Attached are new patches with style
> > fixes, including converting tabs to spaces.
> 
> Some of the original comments still apply:
> 
> On patch 01:
> What was failing? Do you have a testcase that can be added?

These instructions were generating assembly correctly but not machine code. I've added tests.

> 
> On patch 05:
> Please name variables according to:
> http://llvm.org/docs/CodingStandards.html#ll_naming
> What is the "primary" argument for? Please add a comment

Done.

> 
> On patch 06 (was 07)
> Is the assert
> assert(false && "Unhandled case in adjustForSegmentedStacks");
> user visible? i.e., can I hit it running llc targeting an unsupported
> OS?
> Needs a test.

That one should not be user-visible, but I have converted it to report_fatal_error, and used a more descriptive message. The user-visible errors are earlier in that function. I've added a new patch containing test cases for compiling with segmented stacks on unsupported platforms.

> 
> Cheers,
> Rafael
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Explicitly-set-the-scale-to-1-on-some-segstack-prolo.patch
Type: text/x-patch
Size: 3176 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-unsigned-comparison-in-segmented-stack-prologue.patch
Type: text/x-patch
Size: 2571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Generate-the-segmented-stack-prologue-differently-fo.patch
Type: text/x-patch
Size: 2701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Split-segmented-stacks-tests-into-tests-for-static-a.patch
Type: text/x-patch
Size: 4303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Support-segmented-stacks-on-mac.patch
Type: text/x-patch
Size: 6686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Support-segmented-stacks-on-win32.patch
Type: text/x-patch
Size: 3093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Support-segmented-stacks-on-64-bit-FreeBSD.patch
Type: text/x-patch
Size: 2228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-tests-for-mac-segmented-stacks.patch
Type: text/x-patch
Size: 10259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Add-tests-for-win32-segmented-stacks.patch
Type: text/x-patch
Size: 3580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-tests-for-FreeBSD-segmented-stacks.patch
Type: text/x-patch
Size: 3887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Add-error-reporting-tests-for-platforms-that-don-t-s.patch
Type: text/x-patch
Size: 1449 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120109/ae5e4b56/attachment-0010.bin>


More information about the llvm-commits mailing list