[llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD

[Rafael Ávila de Espíndola]

> Thanks for the review, Anton. Attached are new patches with style fixes, including converting tabs to spaces.

Some of the original comments still apply:

On patch 01:
What was failing? Do you have a testcase that can be added?

On patch 05:
Please name variables according to:
http://llvm.org/docs/CodingStandards.html#ll_naming
What is the "primary" argument for? Please add a comment

On patch 06 (was 07)
Is the assert
assert(false && "Unhandled case in adjustForSegmentedStacks");
user visible? i.e., can I hit it running llc targeting an unsupported OS?
Needs a test.

Cheers,
Rafael