[llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD

[Brian Anderson]

----- Original Message -----
> From: "Anton Korobeynikov" <anton at korobeynikov.info>
> To: "Brian Anderson" <banderson at mozilla.com>
> Cc: llvm-commits at cs.uiuc.edu, "Rafael Espindola" <respindola at mozilla.com>
> Sent: Saturday, January 7, 2012 9:40:10 AM
> Subject: Re: [llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD
> 
> Hello Brian
> 
> > For each platform I had to pick a slot in the TCB to store the
> > stack boundary. This is a difficult decision since that is
> > precious real estate. On Win32 I am using the pvArbitrary slot,
> > which is reserved for application use. On FreeBSD it uses
> > tcb_spare.
> win32 part looks ok for me.
> 
> However, please follow the LLVM's Code Style Convention, e.g.:
> 
> 1. Use "if (a ||
>                b)"
> 2. Do not put braces around single line statements in if / else, etc.
> 

Thanks for the review, Anton. Attached are new patches with style fixes, including converting tabs to spaces.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Explicitly-set-the-scale-to-1-on-some-segstack-prolo.patch
Type: text/x-patch
Size: 1686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-unsigned-comparison-in-segmented-stack-prologue.patch
Type: text/x-patch
Size: 2571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Generate-the-segmented-stack-prologue-differently-fo.patch
Type: text/x-patch
Size: 2701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Split-segmented-stacks-tests-into-tests-for-static-a.patch
Type: text/x-patch
Size: 4163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Support-segmented-stacks-on-mac.patch
Type: text/x-patch
Size: 6390 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Support-segmented-stacks-on-win32.patch
Type: text/x-patch
Size: 3197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Support-segmented-stacks-on-64-bit-FreeBSD.patch
Type: text/x-patch
Size: 2276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-tests-for-mac-segmented-stacks.patch
Type: text/x-patch
Size: 9976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Add-tests-for-win32-segmented-stacks.patch
Type: text/x-patch
Size: 3225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-tests-for-FreeBSD-segmented-stacks.patch
Type: text/x-patch
Size: 3459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120107/0a364e22/attachment-0009.bin>