[llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD

Anton Korobeynikov anton at korobeynikov.info
Sat Jan 7 09:40:10 PST 2012


Hello Brian

> For each platform I had to pick a slot in the TCB to store the stack boundary. This is a difficult decision since that is precious real estate. On Win32 I am using the pvArbitrary slot, which is reserved for application use. On FreeBSD it uses tcb_spare.
win32 part looks ok for me.

However, please follow the LLVM's Code Style Convention, e.g.:

1. Use "if (a ||
               b)"
2. Do not put braces around single line statements in if / else, etc.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list