[llvm-commits] [llvm] r147431 - in /llvm/trunk/unittests: Bitcode/ Bitcode/BitReaderTest.cpp Bitcode/Makefile CMakeLists.txt Makefile VMCore/Makefile VMCore/pr11677.cpp

[Chris Lattner]

On Jan 3, 2012, at 3:39 PM, Rafael Ávila de Espíndola wrote:

>> Why not write this as an LTO test in llvm/test/Linker then?
>> 
> 
> I was only able to make this particular manifestation of the bug show up
> with the C lto api or by emulating what it was doing. What is needed is
> running the verifier before the function is materialized.
> 
> I wrote a unit test because I could not reproduce it with the tools in
> the repository, and depending on an external tool (gold) would be bad.
> 
> An option that I considered was changing opt to (optionally?) use the
> lazy bitcode reader. With that I think this test could become just
> 
> llvm-as %s -o %t.bc
> opt -verify %t.bc
> 
> Would that be better?

At this point, I think that keeping the existing unittest is the right way to go (or just remove it).  I don't think spending more time on testing of this trivial fix is worth it :) Thanks Rafael,

-Chris