[llvm-commits] [llvm] r147431 - in /llvm/trunk/unittests: Bitcode/ Bitcode/BitReaderTest.cpp Bitcode/Makefile CMakeLists.txt Makefile VMCore/Makefile VMCore/pr11677.cpp

[Rafael Ávila de Espíndola]

> Why not write this as an LTO test in llvm/test/Linker then?
> 

I was only able to make this particular manifestation of the bug show up
with the C lto api or by emulating what it was doing. What is needed is
running the verifier before the function is materialized.

I wrote a unit test because I could not reproduce it with the tools in
the repository, and depending on an external tool (gold) would be bad.

An option that I considered was changing opt to (optionally?) use the
lazy bitcode reader. With that I think this test could become just

llvm-as %s -o %t.bc
opt -verify %t.bc

Would that be better?

> 
> Why not just use the proper infrastructure we already have for this,
> instead of pushing unit tests?
> 
> -Chris
> 

Cheers,
Rafael