[llvm-commits] [PATCH]fix typo in LegalizeIntegerTypes.cpp

Evan Cheng evan.cheng at apple.com
Wed Jan 4 23:27:03 PST 2012


Has this been reviewed / committed?

Evan

On Dec 25, 2011, at 8:06 AM, Shemer, Anat wrote:

> Hi,
>  
> I found the following typo in WidenVector case of PromoteIntRes_BIT_CONVERT method, where the original output value type is used rather than the type after transformation. I found it in a code review so I have no specific test for it. The diff is below.
>  
> Thanks, Anat
>  
> Index: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
> ===================================================================
> --- lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp   (revision 147140)
> +++ lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp   (working copy)
> @@ -252,9 +252,9 @@
>      return DAG.getNode(ISD::BITCAST, dl, NOutVT, InOp);
>    }
>    case TargetLowering::TypeWidenVector:
> -    if (OutVT.bitsEq(NInVT))
> +    if (NOutVT.bitsEq(NInVT))
>        // The input is widened to the same size.  Convert to the widened value.
> -      return DAG.getNode(ISD::BITCAST, dl, OutVT, GetWidenedVector(InOp));
> +      return DAG.getNode(ISD::BITCAST, dl, NOutVT, GetWidenedVector(InOp));
>    }
>  
>    return DAG.getNode(ISD::ANY_EXTEND, dl, NOutVT,
>  
>  
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies. _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120104/ed109455/attachment.html>


More information about the llvm-commits mailing list