<html><head><base href="x-msg://1910/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Has this been reviewed / committed?<div><br></div><div>Evan</div><div><br><div><div>On Dec 25, 2011, at 8:06 AM, Shemer, Anat wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><font face="Verdana" size="2"><span style="font-size: 10pt; "><div>Hi,</div><div> </div><div>I found the following typo in WidenVector case of PromoteIntRes_BIT_CONVERT method, where the original output value type is used rather than the type after transformation. I found it in a code review so I have no specific test for it. The diff is below.</div><div> </div><div>Thanks, Anat</div><div> </div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">Index: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">===================================================================</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">--- lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (revision 147140)</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">+++ lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (working copy)</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">@@ -252,9 +252,9 @@</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> return DAG.getNode(ISD::BITCAST, dl, NOutVT, InOp);</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> }</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> case TargetLowering::TypeWidenVector:</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">- if (OutVT.bitsEq(NInVT))</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">+ if (NOutVT.bitsEq(NInVT))</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> // The input is widened to the same size. Convert to the widened value.</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">- return DAG.getNode(ISD::BITCAST, dl, OutVT, GetWidenedVector(InOp));</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; ">+ return DAG.getNode(ISD::BITCAST, dl, NOutVT, GetWidenedVector(InOp));</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> }</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> </span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> return DAG.getNode(ISD::ANY_EXTEND, dl, NOutVT,</span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> </span></font></div><div><font face="Calibri" size="2"><span style="font-size: 11pt; "> </span></font></div></span></font><font face="monospace">---------------------------------------------------------------------<br>Intel Israel (74) Limited<br><br>This e-mail and any attachments may contain confidential material for<br>the sole use of the intended recipient(s). Any review or distribution<br>by others is strictly prohibited. If you are not the intended<br>recipient, please contact the sender and delete all copies.</font><span class="Apple-converted-space"> </span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></span></blockquote></div><br></div></body></html>