[llvm-commits] LLVM patch to support ARM fused multiply add/subtract instructions

[Ana Pazos]

Hi Anton,

Thanks for pointing that out. 

Find attached the updated patch that properly sets VFP_arch as vfpv4 if neon is not present.

Thanks,
Ana.

-----Original Message-----
From: Anton Korobeynikov [mailto:anton at korobeynikov.info] 
Sent: Wednesday, January 04, 2012 3:06 PM
To: Ana Pazos
Cc: llvm-commits at cs.uiuc.edu; rajav at codeaurora.org
Subject: Re: [llvm-commits] LLVM patch to support ARM fused multiply add/subtract instructions

Hello Ana,

> Some ARMv7-A processor implementations  (e.g, Qualcomm 8960, ARM Cortex-A5)
> support fused multiply add/subtract instructions (VFMA/VFMS) which have
> lower latency and greater accuracy than the chained multiply add/subtract
> instructions (VMLA/VMLS).
Patch generally looks ok.

However, I'm not sure it's complete wrt build attributes. You're
emitting only text version of neon attribute.
What's about the .fpu stuff and around ? Look into ARMAsmPrinter.cpp a
bit further than your changed lines here.
What if our CPU does not support NEON at all, should we emit something
like ".fpu vfpv4" ?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fusedMACpatch.diff
Type: application/octet-stream
Size: 20695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120104/db073999/attachment.obj>