[llvm-commits] LLVM patch to support ARM fused multiply add/subtract instructions

[Anton Korobeynikov]

Hello Ana,

> Some ARMv7-A processor implementations  (e.g, Qualcomm 8960, ARM Cortex-A5)
> support fused multiply add/subtract instructions (VFMA/VFMS) which have
> lower latency and greater accuracy than the chained multiply add/subtract
> instructions (VMLA/VMLS).
Patch generally looks ok.

However, I'm not sure it's complete wrt build attributes. You're
emitting only text version of neon attribute.
What's about the .fpu stuff and around ? Look into ARMAsmPrinter.cpp a
bit further than your changed lines here.
What if our CPU does not support NEON at all, should we emit something
like ".fpu vfpv4" ?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University