[llvm-commits] [llvm] r147090 - /llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp

[Jakub Staszak]

You are right. Now I realize that I was a little bit too "aggressive" here. I will be more careful in the future.

- Kuba

On Dec 21, 2011, at 10:19 PM, Chandler Carruth wrote:

> On Wed, Dec 21, 2011 at 12:18 PM, Jakub Staszak <kubastaszak at gmail.com> wrote:
> - Change a few operator[] to lookup which is cheaper.
> 
> Cool, but...
>  
> - Add some constantness.
> 
> I really don't like this. There are a lot of methods on MachineBasicBlock that are non-const, and I don't want to have to undo this patch when I discover I need to call one. I don't think this is protecting us from any bugs or enabling any interesting optimizations.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111221/e90fbc3b/attachment.html>