[llvm-commits] [llvm] r147090 - /llvm/trunk/lib/CodeGen/MachineBlockPlacement.cpp

Chandler Carruth chandlerc at google.com
Wed Dec 21 13:19:18 PST 2011


On Wed, Dec 21, 2011 at 12:18 PM, Jakub Staszak <kubastaszak at gmail.com>wrote:

> - Change a few operator[] to lookup which is cheaper.
>

Cool, but...


> - Add some constantness.
>

I really don't like this. There are a lot of methods on MachineBasicBlock
that are non-const, and I don't want to have to undo this patch when I
discover I need to call one. I don't think this is protecting us from any
bugs or enabling any interesting optimizations.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111221/2a5d2a15/attachment.html>


More information about the llvm-commits mailing list